[SSSD] [PATCH v1 1/5] NEW CLIENT: plugin for NFSv4 rpc.idmapd

Lukas Slebodnik lslebodn at redhat.com
Mon Feb 3 08:19:49 UTC 2014


On (02/02/14 11:16), Noam Meltzer wrote:
>> > +    return 0;
>> > +}
>> > +
>> > +static int sss_nfs_princ_to_ids(char *secname, char *princ, uid_t *uid,
>> > +                                gid_t *gid, extra_mapping_params **ex)
>> > +{
>> > +    (void)secname;
>> > +    (void)princ;
>> > +    (void)uid;
>> > +    (void)gid;
>> > +    (void)ex;
>>
>> Why these (void)s ?
>>
>Best practice, IMHO. In case someone decided to enable "
>-Wunused-parameter" in the compile flags.
>(I prefer that over using gcc's __attribute__(unused) )
>

+1

I have almost ready patches forr sssd to enable -Wunused-parameter
and I also prefer casting to void, but I also add a comment e.g.

sss_child_krb5_trace_cb(krb5_context context,
                        const krb5_trace_info *info, void *data)
{
    (void) context; /* unused */
    (void) data; /* unused */

LS



More information about the sssd-devel mailing list