[SSSD] [PATCH] libwbclient: initialize some return values

Sumit Bose sbose at redhat.com
Fri Dec 19 16:48:33 UTC 2014


On Fri, Dec 19, 2014 at 05:12:06PM +0100, Pavel Reichl wrote:
> 
> On 12/19/2014 01:42 PM, Sumit Bose wrote:
> >On Fri, Dec 19, 2014 at 01:31:50PM +0100, Pavel Reichl wrote:
> >>On 12/19/2014 01:07 PM, Sumit Bose wrote:
> >>>Hi,
> >>>
> >>>this patch fixes an issue in SSSD's libwbclient implementation and
> >>>resolves https://fedorahosted.org/sssd/ticket/2537 .
> >>>
> >>>bye,
> >>>Sumit
> >>>
> >>>
> >>>_______________________________________________
> >>>sssd-devel mailing list
> >>>sssd-devel at lists.fedorahosted.org
> >>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >>Hello Sumit,
> >>
> >>thanks for the patch. I have a question regarding the patch:
> >>
> >>>Some callers of libwbclient functions expects the return values are
> >>>initialized even it the functions returns an error.
> >>How can I find out which function are required to do so?
> >>
> >>I noticed you didn't update following function:
> >>
> >>wbcPingDc2(), wbcLogoffUserEx(), wbcLogoffUser()
> >>
> >>I was just wondering how you found out the right functions, sorry if it's a
> >>silly question, but I don't know this part of source yet.
> >I check nsswitch/libwbclient/wbc_pam.c from the samba sources and looked
> >which function set the return values to NULL before returning and error
> >and which not.
> >
> >Btw, to reproduce/test the issue you just have to install
> >samba-winbind-clients (which contains wbinfo) and call
> >
> >  wbinfo -K abc
> >
> >no setup or configuration is needed.
> >
> >bye,
> >Sumit
> Thanks for guidance.
> ACK

Thank you for the review, happy holidays.

Pushed to master:
    082e13dba488ebb2b948d6a362095153714b669f

bye,
Sumit



More information about the sssd-devel mailing list