[SSSD] [PATCH] Skip CHAUTHTOK_PRELIM when using OTPs

Sumit Bose sbose at redhat.com
Mon Dec 15 08:21:37 UTC 2014


On Sat, Dec 13, 2014 at 10:31:19PM +0100, Jakub Hrozek wrote:
> On Fri, Dec 12, 2014 at 05:14:22PM +0100, Sumit Bose wrote:
> > On Thu, Dec 11, 2014 at 10:53:37AM +0100, Jakub Hrozek wrote:
> > > On Thu, Dec 04, 2014 at 10:37:20PM +0100, Jakub Hrozek wrote:
> > > > On Wed, Dec 03, 2014 at 09:44:10AM -0500, Nathaniel McCallum wrote:
> > > > > After further thought, I think this approach is acceptable for 1.12 so
> > > > > long as it is fixed with a better refactoring in 1.13.
> > > > 
> > > > Thank you very much.
> > > > 
> > > > Can one of the SSSD developers give a formal ACK to this patch so I can
> > > > push it upstream (and downstream) ?
> > > 
> > > ping :-)
> > > 
> > > we should get this patch downstream and I'm only available until the end
> > > of this week..or then after Christmas.
> > 
> > I only have a minor issue with the patch the hardcoded "otp" string,
> > but since we currently only support OTPs with FreeIPA it is ok, so ACK.
> > 
> > bye,
> > Sumit
> 
> After a bit of thinking I went ahead and pushed the patch to master:
>     2d40bf0ad9f03e345228cba4563091c91eb02f5b
> 
> mostly because I wasn't sure what would be a good naming that wouldn't
> be so specific as OTP yet we wouldn't have to change it in future when
> we add some more auth tokens. If you have some idea, please file a
> ticket, but at this point I just didn't want to delay downstream. We can
> refactor later.

I agree, this has to be solved when we start other OTP schemes in the
Kerberos backend, then we might even need a new option which is
certainly not needed now.

bye,
Sumit
> 
> Thank you for the review!
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel



More information about the sssd-devel mailing list