[SSSD] [PATCH] SYSDB: sysdb_search_object_by_sid returns ENOENT

Pavel Reichl preichl at redhat.com
Tue Dec 9 11:13:41 UTC 2014


On 12/02/2014 12:50 PM, Lukas Slebodnik wrote:
> On (29/10/14 17:17), Pavel Reichl wrote:
>> Hello,
>>
>> please see attached patch.
>>
>> This patch is part of solution for
>> https://fedorahosted.org/sssd/ticket/1991
>> which aims to unify return values of sysdb calls in case no results are
>> found.
>>
> a) this patch cannot be applied on current master.
rebased
> b) I wrote similar patch becuse sssd_be crashed in function
>      get_object_from_cache. sysdb_search_object_by_sid didn' returned ENOENT and
>      res->msgs was NULL (result: dereference of NULL pointer)
>      -- it is yet another result of broken IPA <-> AD trust
> c) Could you compare your version and mine?
>      Feel free to include my patch to yours if it is not good enogh.
I don't say it was not good enough but I updated my patch.
>
> d) test test_sysdb_delete_by_sid seems to be unrelated to this patch.
>     I would prefer to have it in separete patch.
I have moved it to separate patch. This patch is just to verify that 
sysdb_delete_by_sid() was not changed by the second patch.
>
> LS
>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Thanks, please see updated patches.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141209/dd1477f3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-TESTS-sysdb_delete_by_sid-test-return-value.patch
Type: text/x-patch
Size: 2071 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141209/dd1477f3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-SYSDB-sysdb_search_object_by_sid-returns-ENOENT.patch
Type: text/x-patch
Size: 9817 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141209/dd1477f3/attachment-0001.bin>


More information about the sssd-devel mailing list