[SSSD] [PATCHES] DING-LIBS Collection and INI patches for INI object modification API - UPDATED

Dmitri Pal dpal at redhat.com
Mon Dec 8 19:19:30 UTC 2014


On 12/08/2014 01:10 PM, Pavel Březina wrote:
> On 12/08/2014 10:46 AM, Jakub Hrozek wrote:
>> On Sun, Dec 07, 2014 at 06:26:06PM -0500, Dmitri Pal wrote:
>>> On 12/07/2014 05:32 PM, Dmitri Pal wrote:
>>>> Hello,
>>>>
>>>> First three patches introduce changes to collection that were 
>>>> needed for
>>>> the implementation of the INI object modification API
>>>> The rest are for the INI itself. I made recommended changes and 
>>>> cleaned
>>>> doxygen comments a bit.
>>>>
>>>> The INI interface so far does not include:
>>>> a) Saving to file - function requested by Pavel
>>>> b) Sorting
>>>>
>>>> I plan to provide this functionality in the follow up patches.
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> sssd-devel mailing list
>>>> sssd-devel at lists.fedorahosted.org
>>>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>> Cleaned couple things.
>>> This is a better set
>>
>> Pavel, can you check if the API would allow you to use libini_config
>> instead of augeas?
>>
>
> For some reason the patches are not directly applicable by git. I had 
> to remove the first character '>' from each patch before applying. 
> After that, it cannot be applied to the ding-libs master, it fails with:
>
> error: patch failed: Makefile.am:251
> error: Makefile.am: patch does not apply
> Patch failed at 0009 Build new interface
>
> Are those patches dependent on some other patches?
>
> Anyway, the interface should be good. I guess that the only thing I am 
> missing from augeas functionality is the save function.
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

I am puzzled how ">" ended up in all the patches.
I regenerated a new set and there is no ">" there.

Also you are right. I have a patch that is in my tree since for me 
autotools do not work with the current Makefile.am. I had to make a one 
line change but it is close to the place where I did other change so 
patch 9 might not apply cleanly. To avoid that I moved the lines around 
and generated a new version of patch 9. I hope it would apply cleanly.

Thanks for checking!

The save part will be done as a part of the fileobj API. It will include 
functions like:
- save backup in the given location
- change file ownership/permissions
- save file

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager IdM portfolio
Red Hat, Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-COLLECTION-Function-to-return-one-of-the-dups.patch
Type: text/x-patch
Size: 39159 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-COLLECTION-Allow-to-modify-item-name.patch
Type: text/x-patch
Size: 1870 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-COLLECTION-Expose-delete-with-callback-function.patch
Type: text/x-patch
Size: 2417 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-INI-Comment-creation-helper.patch
Type: text/x-patch
Size: 5255 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-INI-Comment-can-be-NULL.patch
Type: text/x-patch
Size: 803 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-INI-Cleaning-doxygen-comments.patch
Type: text/x-patch
Size: 3799 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-INI-Generate-doxy-doc-for-INI-modification-API.patch
Type: text/x-patch
Size: 968 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-INI-Build-new-interface.patch
Type: text/x-patch
Size: 3441 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-INI-New-interface-to-modify-configuration.patch
Type: text/x-patch
Size: 121819 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-INI-Move-definition-to-common-header.patch
Type: text/x-patch
Size: 1610 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-INI-Fix-wrapping-error.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141208/ee5ad19a/attachment-0010.bin>


More information about the sssd-devel mailing list