[SSSD] [PATCH] CI: Suppress memory errors from poptGetNextOpt

Jakub Hrozek jhrozek at redhat.com
Fri Dec 5 19:08:22 UTC 2014


On Fri, Dec 05, 2014 at 06:04:19PM +0200, Nikolai Kondrashov wrote:
> On 12/05/2014 05:54 PM, Nikolai Kondrashov wrote:
> >On 12/05/2014 11:03 AM, Jakub Hrozek wrote:
> >>+# long-standing memory leak in popt
> >>+{
> >>+   popt-memleak-from-poptGetNextOpt-realloc
> >>+   Memcheck:Leak
> >>+   match-leak-kinds: definite
> >
> >Old versions of Valgrind (including the one in RHEL6) don't differentiate leak
> >confidence and abort on encountering this field.
> >
> >It looks like this:
> >http://sssd-ci.duckdns.org/logs/job/4/74/rhel6/ci-build-debug/auth-tests.10780.valgrind.log
> >
> >Please remove these.
> 
> I mean just removing these lines:
> 
>     match-leak-kinds: definite
> 
> is enough.
> 
> Nick

Ah, thank you. In my defense, I didn't even get that far in my testing
as #2518 meant SSSD didn't go that far.

Thanks for the review. A new patch is attached.
-------------- next part --------------
>From 971937d464aa2192c97f75e2ba47425588faf0fc Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Thu, 4 Dec 2014 21:12:45 +0100
Subject: [PATCH] CI: Suppress memory errors from poptGetNextOpt

---
 contrib/ci/sssd.supp | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/contrib/ci/sssd.supp b/contrib/ci/sssd.supp
index 5bd8c8d699d8807c260966f7e08dee312a0938c6..b9d13cdd699513df6a84b90badc2ef43c863835d 100644
--- a/contrib/ci/sssd.supp
+++ b/contrib/ci/sssd.supp
@@ -122,3 +122,32 @@
    fun:exit
    fun:(below main)
 }
+
+# long-standing memory leak in popt
+{
+   popt-memleak-from-poptGetNextOpt-malloc
+   Memcheck:Leak
+   fun:malloc
+   ...
+   fun:poptGetNextOpt
+   fun:main
+}
+
+# long-standing memory leak in popt
+{
+   popt-memleak-from-poptGetNextOpt-realloc
+   Memcheck:Leak
+   fun:realloc
+   ...
+   fun:poptGetNextOpt
+   fun:main
+}
+
+# popt was not good with read access either. Applies for popt <= 1.13
+{
+    popt-suppress-invalid-read
+    Memcheck:Addr4
+    ...
+    fun:poptGetNextOpt
+    fun:main
+}
-- 
1.9.3



More information about the sssd-devel mailing list