[SSSD] [PATCH] tests: Free popt_context

Jakub Hrozek jhrozek at redhat.com
Fri Dec 5 08:31:45 UTC 2014


On Thu, Dec 04, 2014 at 11:43:02PM +0100, Lukas Slebodnik wrote:
> On (04/12/14 22:50), Jakub Hrozek wrote:
> >caught by CI..
> 
> >From 507aa36664640ac187f1289889c9ceb7bd944b0c Mon Sep 17 00:00:00 2001
> >From: Jakub Hrozek <jhrozek at redhat.com>
> >Date: Thu, 4 Dec 2014 18:04:35 +0100
> >Subject: [PATCH] tests: Free popt_context
> >
> >---
> > src/tests/cmocka/dummy_child.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/src/tests/cmocka/dummy_child.c b/src/tests/cmocka/dummy_child.c
> >index 0bb50a4e005a26b1fbd332b17558d1284de77ea1..1a6b5fa0209c634a12bb0f3979ef4df1cca7dcb9 100644
> >--- a/src/tests/cmocka/dummy_child.c
> >+++ b/src/tests/cmocka/dummy_child.c
> >@@ -69,6 +69,7 @@ int main(int argc, const char *argv[])
> >             _exit(1);
> >         }
> >     }
> >+    poptFreeContext(pc);
> You should call poptFreeContext also before "_exit(1)" 3 lines before this
> change.
> 
> LS

thanks, done. See the attached patch.
-------------- next part --------------
>From 35d4ba31c4ce6c27bdbc3536ffd8a98764af7da8 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Thu, 4 Dec 2014 18:04:35 +0100
Subject: [PATCH] tests: Free popt_context

---
 src/tests/cmocka/dummy_child.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/tests/cmocka/dummy_child.c b/src/tests/cmocka/dummy_child.c
index 0bb50a4e005a26b1fbd332b17558d1284de77ea1..057fa6450b51cbac589e64553bb0692cbbfac655 100644
--- a/src/tests/cmocka/dummy_child.c
+++ b/src/tests/cmocka/dummy_child.c
@@ -66,9 +66,11 @@ int main(int argc, const char *argv[])
         fprintf(stderr, "\nInvalid option %s: %s\n\n",
                   poptBadOption(pc, 0), poptStrerror(opt));
             poptPrintUsage(pc, stderr, 0);
+            poptFreeContext(pc);
             _exit(1);
         }
     }
+    poptFreeContext(pc);
 
     action = getenv("TEST_CHILD_ACTION");
     if (action) {
-- 
1.9.3



More information about the sssd-devel mailing list