[SSSD] [PATCH] CI: Update valgrind suppresion database for libselinux

Jakub Hrozek jhrozek at redhat.com
Thu Dec 4 21:22:34 UTC 2014


On Thu, Dec 04, 2014 at 11:09:30AM +0100, Lukas Slebodnik wrote:
> On (03/12/14 22:00), Jakub Hrozek wrote:
> >On Wed, Dec 03, 2014 at 09:15:45PM +0100, Lukas Slebodnik wrote:
> >> On (03/12/14 21:44), Nikolai Kondrashov wrote:
> >> >On 12/03/2014 07:23 PM, Lukas Slebodnik wrote:
> >> >>On (03/12/14 18:17), Jakub Hrozek wrote:
> >> >>>On Wed, Dec 03, 2014 at 10:18:33AM -0500, Lukas Slebodnik wrote:
> >> >>>>----- Original Message -----
> >> >>>>>From: "Nikolai Kondrashov" <Nikolai.Kondrashov at redhat.com>
> >> >>>>>To: "Development of the System Security Services Daemon" <sssd-devel at lists.fedorahosted.org>
> >> >>>>>Sent: Wednesday, December 3, 2014 4:00:14 PM
> >> >>>>>Subject: Re: [SSSD] [PATCH] CI: Update valgrind suppresion database for	libselinux
> >> >>>>>
> >> >>>>>On 12/03/2014 04:23 PM, Lukas Slebodnik wrote:
> >> >>>>>>  From 7f041a011f44a8fb1c128095ad55c0669287209d Mon Sep 17 00:00:00 2001
> >> >>>>>>From: Lukas Slebodnik<lslebodn at redhat.com>
> >> >>>>>>Date: Wed, 3 Dec 2014 14:34:43 +0100
> >> >>>>>>Subject: [PATCH 1/2] CI: Update valgrind suppresion database for libselinux
> >> >>>>>>
> >> >>>>>>problem is already fixed in fedora >= 21
> >> >>>>>
> >> >>>>>Thanks, Lukas!
> >> >>>>>Do you have any information on what the problem was?
> >> >>>>>
> >> >>>>I'm sorry it isn't important information for me.
> >> >>>>Problem is fixed on fedora 21. And that's al what I need to know.
> >> >>>>
> >> >>>>LS
> >> >>>
> >> >>>Can you change the name as Nikolai requested so that we can push the
> >> >>>patch and unbreak CI?
> >> >>I do not see a reason why there should be prefix sssd-
> >> >>
> >> >>The problem is in libselinux and not in sssd.
> >> >
> >> >Yes, but this way we'll also be able to see that it is *our* suppression and
> >> >not some other package suppression from /usr/lib64/valgrind.
> >> >
> >> valgrind will not use prefix "libselinux-"
> >
> >I really don't want to spend more time on naming of a valgrind
> >suppresion. I think I, and I hope other developers too, have more
> >important things to do.
> >
> >If the patch solves the problem, then fine.
> I added problematic function from libseliux to description.
> 
> LS

> From 68d45177a4c444bb7add87bc3d0179f18f2beaa5 Mon Sep 17 00:00:00 2001
> From: Lukas Slebodnik <lslebodn at redhat.com>
> Date: Wed, 3 Dec 2014 14:34:43 +0100
> Subject: [PATCH] CI: Update valgrind suppresion database for libselinux
> 
> The problem is already fixed in fedora >= 21
> ---
>  contrib/ci/sssd.supp | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/contrib/ci/sssd.supp b/contrib/ci/sssd.supp
> index 631e1d6f287a21f15ec518628e4c6664373e573a..5bd8c8d699d8807c260966f7e08dee312a0938c6 100644
> --- a/contrib/ci/sssd.supp
> +++ b/contrib/ci/sssd.supp
> @@ -109,3 +109,16 @@
>     fun:g_utf8_casefold
>     ...
>  }
> +
> +# uninitialised value in libselinux (fixed in fedora >= 21)
> +{
> +   libselinux-jump-or-move-depends-on-uninitialised-value-in-selabel_close
> +   Memcheck:Cond
> +   obj:/usr/lib64/libselinux.so.1
> +   fun:selabel_close
> +   obj:/usr/lib64/libkrb5support.so.0.1

Can you use:
    obj:/usr/lib*/libkrb5support.so.0.1

Here instead, so the suppression works on 32bit as well?

> +   fun:_dl_fini
> +   fun:__run_exit_handlers
> +   fun:exit
> +   fun:(below main)
> +}
> -- 
> 2.1.0
> 

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list