[SSSD] [PATCH] KRB5: Relax DEBUG message

Sumit Bose sbose at redhat.com
Wed Dec 3 08:55:52 UTC 2014


On Tue, Dec 02, 2014 at 10:07:10PM +0100, Jakub Hrozek wrote:
> Without relaxing the DEBUG message, a clean install of SSSD would print
> a CRIT-level DEBUG message which is not what we want.

ACK, but please note that the plain krb5 error code might not be easy to
translate, maybe you can add a KRB5_CHILD_DEBUG() to get the error
message as well?

> From 6a93f95d6921a233f6575f8bc46af08796595df7 Mon Sep 17 00:00:00 2001
> From: Jakub Hrozek <jhrozek at redhat.com>
> Date: Fri, 28 Nov 2014 19:56:27 +0100
> Subject: [PATCH] KRB5: Relax DEBUG message
> 
> ---
>  src/providers/krb5/krb5_child.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
> index 3db2955d86f79ca95376ec91e81d794630ae00e8..2c0a881864053d7428f64db77621417384afcfb6 100644
> --- a/src/providers/krb5/krb5_child.c
> +++ b/src/providers/krb5/krb5_child.c
> @@ -1680,8 +1680,11 @@ static krb5_error_code get_tgt_times(krb5_context ctx, const char *ccname,
>      mcred.client = client_principal;
>  
>      krberr = krb5_cc_retrieve_cred(ctx, ccache, 0, &mcred, &cred);
> -    if (krberr != 0) {
> -        DEBUG(SSSDBG_CRIT_FAILURE, "krb5_cc_retrieve_cred failed.\n");
> +    if (krberr == KRB5_FCC_NOFILE) {
> +        DEBUG(SSSDBG_TRACE_LIBS, "FAST ccache must be recreated\n");
> +    } else if (krberr != 0) {
> +        DEBUG(SSSDBG_CRIT_FAILURE,
> +              "krb5_cc_retrieve_cred failed: %d\n", krberr);
>          krberr = 0;
>          goto done;
>      }
> -- 
> 1.9.3
> 

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list