[SSSD] [PATCH] libwbclient: SSSD implementation

Lukas Slebodnik lslebodn at redhat.com
Wed Aug 27 09:31:27 UTC 2014


On (21/08/14 13:38), Sumit Bose wrote:
>On Thu, Aug 21, 2014 at 01:27:58PM +0200, Jakub Hrozek wrote:
>> On Wed, Aug 20, 2014 at 05:38:56PM +0200, Sumit Bose wrote:
>> > > > wbcGetgrnam and wbcGetgrnam have wrong comments, but this trivial bug is
>> > > > also in Samba.
>> > > > 
>> > > > Are you sure the asprintf() call in wbcLookupName is safe? Could this
>> > > > enable someone to trash the stack with a long enough name?
>> > > 
>> > > I added some checks to prevent this.
>> 
>> For some reason I thought that asprintf allocates on the stack like
>> alloca and didn't see the call to free. In this case, I don't think the
>> check is needed.
>
>I think the NULL checks still make sense and if you agree I would keep
>the others just as sanity checks.
>

libwbclient is installed by default with make install
and there isn't way how to disable this behaviour.
Should we add possibility to build (or install) library  optionaly?
It might help package maintainers.

LS



More information about the sssd-devel mailing list