[SSSD] [PATCHES] check return value

Lukas Slebodnik lslebodn at redhat.com
Wed Aug 27 09:20:15 UTC 2014


On (26/08/14 19:15), Jakub Hrozek wrote:
>On Tue, Aug 26, 2014 at 05:43:16PM +0200, Pavel Reichl wrote:
>> >>>If you have time to convert the debug messages, then by all means, send
>> >>>a patch. Maybe this could be a nice intern task? :-)
>> >What about this patch?
>> >
>> >LS
>> Your patch definitely fixes clang warning. I studied the patch and nearby
>> code and it seems to me that we are not breaking anything.
>> 
>> It would be great to refactor this function soon as I personally find it
>> really hard to understand.
>> 
>> ACK
>
>Pushed to master as 72db1f3ce67b0634f2843088f1198b3b350b72ab
>
>Can you also provide a version that applies cleanly on top of sssd-1-11
>?
I realized this problem is not in sssd-1-11 branch.

It was caused by commit 8a8618717c99b7331125fa736b45d9155da797d3,
Author: Jakub Hrozek <jhrozek at redhat.com>
Date:   Tue Mar 11 17:39:31 2014 +0100

    Only check GID if ID-mapping


And this commit was not backported to 1-11 branch.

LS



More information about the sssd-devel mailing list