[SSSD] [PATCH] LDAP: Do not shortcut on ret != EOK during password expiry check

Lukas Slebodnik lslebodn at redhat.com
Fri Aug 22 11:07:19 UTC 2014


On (20/08/14 16:56), Jakub Hrozek wrote:
>https://fedorahosted.org/sssd/ticket/2323
>
>The functions that check for password expiration can return non-zero
>return codes not only on internal failure, but also to indicate that the
>password was expired. The code would in this case shortcut in the error
>handler instead of making its way to the switch-case code below that
>translates the SSSD error codes into PAM error codes.
>
>We don't lose the error reporting, because any internal error would
>translate into PAM_SYSTEM_ERROR anyway.

>From 563ebe442d546c8cc7e71a93b45c88241088c277 Mon Sep 17 00:00:00 2001
>From: Jakub Hrozek <jhrozek at redhat.com>
>Date: Wed, 20 Aug 2014 16:44:49 +0200
>Subject: [PATCH] LDAP: Do not shortcut on ret != EOK during password expiry
> check
>
>https://fedorahosted.org/sssd/ticket/2323
>
>The functions that check for password expiration can return non-zero
>return codes not only on internal failure, but also to indicate that the
>password was expired. The code would in this case shortcut in the error
>handler instead of making its way to the switch-case code below that
>translates the SSSD error codes into PAM error codes.
>
>We don't lose the error reporting, because any internal error would
>translate into PAM_SYSTEM_ERROR anyway.
>---
work as expected

ACK

LS



More information about the sssd-devel mailing list