[SSSD] [PATCH] Make the replace-space functionality usable for other responders

Pavel Březina pbrezina at redhat.com
Mon Aug 11 12:25:02 UTC 2014


On 08/11/2014 09:54 AM, Jakub Hrozek wrote:
> On Mon, Aug 11, 2014 at 09:12:24AM +0200, Lukas Slebodnik wrote:
>> It is your decision. You can:
>>      a) fix problem in function ifp_user_get_attr_search
>>      b) remove changes in IFP responder.
>>
>> LS
>
> Thanks for the quick review. I would prefer to keep the ifp changes in
> -- I don't realistically expect anyone being bitten by spaces when using
> InfoPipe, but it's more about being consistent. When we say we want to
> replace the spaces, we should replace them everywhere..

Patch 1:
Ack.

Patch 2:
Man page says "override_space", but you renamed the option to 
"override_default_space". Actually I like the first name better, can you 
switch it back? Or what is the reason for using "default" word?

Patch 3:
Ack.

However, I'm not really sure it is a good idea to allow both logins. 
Wouldn't it be better to allow only one depending whether the option is 
set or not?

Patch 4:
Ack.

Patch 5:
Ack.

Path 6:
Ack.

The code is good, however, I still see the problem that the 
transformation is not symmetrical. If an input contains the replacement 
character, we cannot perform reverse transformation correctly. Either we 
have to very loudly warn that the character must be unused all over the 
database or fix it.

For example I have two users: user-1, "user 4" and I choose '-' as 
replacement character. user-1 is not able to login.



More information about the sssd-devel mailing list