[SSSD] [PATCH] Two patches with more debugging for the LDAP provider

Jakub Hrozek jhrozek at redhat.com
Tue Aug 5 10:43:05 UTC 2014


On Mon, Jul 21, 2014 at 12:33:16PM +0200, Jakub Hrozek wrote:
> On Mon, Jul 21, 2014 at 10:42:05AM +0200, Pavel Březina wrote:
> > >>+    if (!(debug_level & SSSDBG_TRACE_INTERNAL)) {
> > >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > >        type of this expression is integer and not boolean :-)
> > 
> > We have DEBUG_IS_SET macro for this type of tests.
> 
> OK, I removed the explicit '\0' and used DEBUG_IS_SET().

Pavel mentioned on IRC I managed to reverse the condition of
DEBUG_IS_SET.
-------------- next part --------------
>From 8ccabaf060ab6665258c42f43fc223b6e7c409ae Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 18 Jul 2014 15:04:28 +0200
Subject: [PATCH 1/2] LDAP: Print referrals for debugging purposes

---
 src/providers/ldap/sdap_async.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c
index 2959862dd82921c984fc4785008d346559b19d35..0ce874707e849429878fde0c0bf6773987b2ff0c 100644
--- a/src/providers/ldap/sdap_async.c
+++ b/src/providers/ldap/sdap_async.c
@@ -1335,6 +1335,8 @@ static void sdap_get_generic_ext_done(struct sdap_op *op,
     struct sdap_get_generic_ext_state *state = tevent_req_data(req,
                                             struct sdap_get_generic_ext_state);
     char *errmsg = NULL;
+    int i;
+    char **refs = NULL;
     int result;
     int ret;
     int lret;
@@ -1370,7 +1372,7 @@ static void sdap_get_generic_ext_done(struct sdap_op *op,
 
     case LDAP_RES_SEARCH_RESULT:
         ret = ldap_parse_result(state->sh->ldap, reply->msg,
-                                &result, NULL, &errmsg, NULL,
+                                &result, NULL, &errmsg, &refs,
                                 &returned_controls, 0);
         if (ret != LDAP_SUCCESS) {
             DEBUG(SSSDBG_OP_FAILURE,
@@ -1383,6 +1385,13 @@ static void sdap_get_generic_ext_done(struct sdap_op *op,
                   sss_ldap_err2string(result), result,
                   errmsg ? errmsg : "no errmsg set");
 
+        if (refs != NULL) {
+            for (i = 0; refs[i]; i++) {
+                DEBUG(SSSDBG_TRACE_LIBS, "Ref: %s\n", refs[i]);
+            }
+            ldap_memvfree((void **) refs);
+        }
+
         if (result == LDAP_SIZELIMIT_EXCEEDED) {
             /* Try to return what we've got */
             DEBUG(SSSDBG_MINOR_FAILURE,
-- 
1.9.3

-------------- next part --------------
>From 400ac00132d79cf7c9abd5134b85e8b5f60e0ef7 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 18 Jul 2014 15:37:34 +0200
Subject: [PATCH 2/2] LDAP: Dump LDAP server IP address with a high DEBUG level

---
 src/providers/ldap/sdap_async.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c
index 0ce874707e849429878fde0c0bf6773987b2ff0c..4100f6d1459907c4e6f7dad492083e2a46d8dd5d 100644
--- a/src/providers/ldap/sdap_async.c
+++ b/src/providers/ldap/sdap_async.c
@@ -1083,6 +1083,40 @@ static errno_t add_to_deref_reply(TALLOC_CTX *mem_ctx,
     return EOK;
 }
 
+static void sdap_print_server(struct sdap_handle *sh)
+{
+    int ret;
+    int fd;
+    struct sockaddr_storage ss;
+    socklen_t ss_len = sizeof(ss);
+    char ip[NI_MAXHOST];
+
+    if (!DEBUG_IS_SET(SSSDBG_TRACE_INTERNAL)) {
+        return;
+    }
+
+    ret = get_fd_from_ldap(sh->ldap, &fd);
+    if (ret != EOK) {
+        DEBUG(SSSDBG_MINOR_FAILURE, "cannot get sdap fd\n");
+        return;
+    }
+
+    ret = getsockname(fd, (struct sockaddr *) &ss, &ss_len);
+    if (ret == -1) {
+        DEBUG(SSSDBG_MINOR_FAILURE, "getsockname failed\n");
+        return;
+    }
+
+    ret = getnameinfo((struct sockaddr *) &ss, ss_len,
+                      ip, sizeof(ip), NULL, 0, NI_NUMERICHOST);
+    if (ret != 0) {
+        DEBUG(SSSDBG_MINOR_FAILURE, "getnameinfo failed\n");
+        return;
+    }
+
+    DEBUG(SSSDBG_TRACE_INTERNAL, "Searching %s\n", ip);
+}
+
 /* ==Generic Search exposing all options======================= */
 typedef errno_t (*sdap_parse_cb)(struct sdap_handle *sh,
                                  struct sdap_msg *msg,
@@ -1172,6 +1206,8 @@ sdap_get_generic_ext_send(TALLOC_CTX *memctx,
         return req;
     }
 
+    sdap_print_server(sh);
+
     /* Be extra careful and never allow paging for BASE searches,
      * even if requested.
      */
-- 
1.9.3



More information about the sssd-devel mailing list