[SSSD] [PATCH] LDAP: Avoid undefined ret value

Jakub Hrozek jhrozek at redhat.com
Mon Aug 4 13:56:34 UTC 2014


Hi,

please see the attached patch. An alternative might be to git revert
e3c994b7b779e6d6d6d125ee28d30bd139590f49, I'm fine either way.
-------------- next part --------------
>From 579e5725f2be3323df777e6a1817220884d9ff0e Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Mon, 4 Aug 2014 15:48:56 +0200
Subject: [PATCH] LDAP: Avoid undefined ret value

If the LDAP schema was set to a different value than AD and ID mapping
was enabled, the value of ret was not defined.

Make sure we define ret for the condition below with the
default for ID mapping which is 'no GID'
---
 src/providers/ldap/sdap_async_nested_groups.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/providers/ldap/sdap_async_nested_groups.c b/src/providers/ldap/sdap_async_nested_groups.c
index 5398b14bc0e163c122def1c3d729b28d72873b82..18a811c771206b97c70961f47ca9b3ec57f6593a 100644
--- a/src/providers/ldap/sdap_async_nested_groups.c
+++ b/src/providers/ldap/sdap_async_nested_groups.c
@@ -240,7 +240,7 @@ sdap_nested_group_hash_group(struct sdap_nested_group_ctx *group_ctx,
 {
     struct sdap_attr_map *map = group_ctx->opts->group_map;
     gid_t gid;
-    errno_t ret;
+    errno_t ret = ENOENT;
     int32_t ad_group_type;
     bool posix_group = true;
     bool use_id_mapping;
-- 
1.9.3



More information about the sssd-devel mailing list