[SSSD] [PATCH] AD: LDAP component of GPO-based access control

Yassir Elley yelley at redhat.com
Wed Apr 30 16:06:17 UTC 2014



----- Original Message -----
> On (29/04/14 19:22), Yassir Elley wrote:
> >Hi Jakub,
> >
> >I have attached a revised cumulative patch that aims to address the review
> >comments.
> >
> >Additionally, I made the following changes en masse:
> >* changed talloc_strdup() to talloc_steal() when applicable (i.e. when
> >dealing with a talloc context)
> >* changed all occurrences of strerror() to sss_strerror() in order to use
> >sssd-specific error strings
> >
> >Thanks,
> >Yassir.
> 
> >From 5fd5fec3d92daa38e324195de01f8f596b03a0d7 Mon Sep 17 00:00:00 2001
> >From: Yassir Elley <yelley at redhat.com>
> >Date: Mon, 20 Jan 2014 11:17:06 -0500
> >Subject: [PATCH] Implemented LDAP component of GPO-based access control
> >
> >---
> There were same warnings in your patch.
>     warning: assignment discards 'const' qualifier from pointer target type
> 
> Attached diff fixes some of them.
> 
> There is also another warning.
> src/providers/ad/ad_gpo.c: In function 'ad_gpo_get_gpo_attrs_done':
> sssd/src/providers/ad/ad_gpo.c:2131:19: error: assignment discards 'const'
> qualifier from pointer target type [-Werror]
>      file_sys_path = talloc_steal(gp_gpo, raw_file_sys_path);
>                    ^
> 
> There should be strdup, because file_sys_path is modified in function
> ad_gpo_convert_to_smb_uri.
> 
> LS
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> 

Hi Lukas,

Thanks for catching this. I sometimes compile, see the warnings, and think I'll get back to fixing them later (after I install and test code). However, if I don't change the code and want to see the warnings again (since they have scrolled off the screen by this point), a subsequent compile doesn't show the warnings. I guess I should fix them right when I see them, rather than waiting.

My revised cumulative patch is attached. In addition to your suggestions, I have added the "const" qualifier to a few more places.

Thanks,
Yassir.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Implemented-LDAP-component-of-GPO-based-access-contr.patch
Type: text/x-patch
Size: 107413 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140430/5afea234/attachment.bin>


More information about the sssd-devel mailing list