[SSSD] [PATCH] TEST: Some macros aren't defined in older version of check.

Michal Židek mzidek at redhat.com
Thu Apr 24 11:48:19 UTC 2014


On 04/24/2014 09:37 AM, Lukas Slebodnik wrote:
> On (23/04/14 23:38), Michal Židek wrote:
>> On 04/22/2014 09:55 AM, Lukas Slebodnik wrote:
>>> ehlo,
>>>
>>> attached patch fixes errors on RHEL6
>>>
>>> LS
>>>
>>>
>>
>> I had these errors on Fedora 17 and 19 as well.
>> The patch fixes them for me.
>>
>> But since the macros are taken from check's source code, wouldn't
>> it be appropriate to put reference into the code? Something like
>> /* These macros were taken from check's project source files.
>> * http://check.sourceforge.net/
>> */
> Comment was added.
>
>> Otherwise the patch is OK.
>>
>
> Thank you for review.
>
> New version is attached.
>
> LS
>
>

Ack.

Michal




More information about the sssd-devel mailing list