[SSSD] [PATCH] DBus: Automatic pack/unpack of method handler arguments

Pavel Březina pbrezina at redhat.com
Fri Apr 18 08:37:57 UTC 2014


On 04/17/2014 05:17 PM, Jakub Hrozek wrote:
> On Thu, Apr 17, 2014 at 02:46:06PM +0200, Pavel Březina wrote:
>> On 03/20/2014 08:11 AM, Stef Walter wrote:
>>> On 14.03.2014 23:00, Stef Walter wrote:
>>>> Here's the next set of DBus patches. This implements automatic packing
>>>> and unpacking of arguments for method handlers.
>>>
>>> Rebased on master. Also the last patches had incorrectly generated files
>>> due to a rebase.
>>>
>>> Stef
>>
>> Hi,
>> I'm sorry for the delay. Can you rebase the patches one more time please?
>
> I took the liberty of rebasing the patches on Stef's behalf as the only
> conflict was in the Introspection piece I wrote. The first patch (a new
> one) silences the warning about undefined method.
>
> The second and third are what used to be first and second previously.

Thanks.

First patch should be the last one, since invoker field is not present 
before Stef's patches.

0001: Ack, but maybe amend the commit message that it fixes the warning.

0002: C-code ack... I didn't go through the Python code though, I left 
that for someone more experienced with Python.

0003: Ack.

Smoke tests went fine.

Great work Stef!

I'm attaching two more patches that fixes few warnings. Feel free to 
squash them into Stef's first patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-SBUS-Create-an-sbus_method_meta-instance-for-Introsp.patch
Type: text/x-patch
Size: 2348 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140418/7c720822/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sbus-Add-type-safe-DBus-method-handlers-and-finish-f.patch
Type: text/x-patch
Size: 50042 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140418/7c720822/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-sbus_codegen_tests-Add-test-case-type-safe-handler-a.patch
Type: text/x-patch
Size: 32617 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140418/7c720822/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-sbus_tests-fix-missing-invoker-in-initializer.patch
Type: text/x-patch
Size: 992 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140418/7c720822/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-sbus-request-fix-error-initialization.patch
Type: text/x-patch
Size: 1695 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140418/7c720822/attachment-0004.bin>


More information about the sssd-devel mailing list