[SSSD] [PATCH] DBus: Refactor how requests are handled

Jakub Hrozek jhrozek at redhat.com
Thu Apr 17 15:21:17 UTC 2014


On Wed, Apr 16, 2014 at 02:51:36PM +0200, Lukas Slebodnik wrote:
> >+    if (handler_fn) {
> >+        dbus_req = sbus_new_request(intf_p->conn, intf_p->intf, message);
> >+        if (!dbus_req) {
> >+            ret = ENOMEM;
> >+        } else {
> >+            dbus_req->method = method;
> //I can see warning on fedora rawhide with default CFLAGS (-g -O2)
> 
> src/sbus/sssd_dbus_connection.c: In function 'sbus_message_handler':
> src/sbus/sssd_dbus_connection.c:454:30: warning: 'method' may be used uninitialized in this function [-Wmaybe-uninitialized]
>              dbus_req->method = method;
> 
>                               ^
> 

Thanks for noticing this, a patch was added to the thread called
"[PATCH] DBus: Automatic pack/unpack of method handler arguments".



More information about the sssd-devel mailing list