[SSSD] [PATCHES] check return value

Lukas Slebodnik lslebodn at redhat.com
Wed Apr 9 20:38:25 UTC 2014


On (09/04/14 21:19), Sumit Bose wrote:
>On Wed, Apr 09, 2014 at 07:27:28PM +0200, Pavel Reichl wrote:
>> On Mon, 2014-04-07 at 18:13 +0200, Sumit Bose wrote:
>> > On Mon, Apr 07, 2014 at 02:22:04PM +0200, Pavel Reichl wrote:
>> > > Hello,
>> > > 
>> > > I noticed these two warnings in clang.
>> > > 
>> > > It would be great if the 2nd patch could be checked by Sumit to make
>> > > sure that the return value wasn't ignored on purpose.
>> > 
>> > yes, I would prefer to ignore errors here. There might be various cases
>> > were we are not able to resolve a single SID but still can proceed with
>> > the others.
>> 
>> Please see attached patch. Feel free to NACK it, if you think it's more
>> pain than gain.
>
>Why not do something useful to avoid the compiler warning and print a
>SSSDBG_TRACE_ALL debug message with the returned error code in the case
>of an error?
>
+1

LS



More information about the sssd-devel mailing list