[SSSD] [PATCHES] Fix old ccache testing behavior

Jakub Hrozek jhrozek at redhat.com
Wed Sep 25 12:12:08 UTC 2013


On Wed, Sep 25, 2013 at 02:04:11PM +0200, Jakub Hrozek wrote:
> On Tue, Sep 24, 2013 at 08:53:32AM -0400, Simo Sorce wrote:
> > On Tue, 2013-09-24 at 12:59 +0200, Jakub Hrozek wrote:
> > > On Fri, Sep 20, 2013 at 01:04:06PM -0400, Simo Sorce wrote:
> > > > Addresses #2053 and #2094
> > > > 
> > > > Check old ccaches only if needed, always precreate containing directory
> > > > if we are goign to proceed with authentication and always fallback to
> > > > old algorithm to check user presence on the system if systemd-login
> > > > fails or returns negative result.
> > > > 
> > > > (Patches as agreed on IRC after several discussions)
> > > > 
> > > > All tested and apparently working.
> > > 
> > > Sorry, I didn't have the time to test the first two patches yet, but I'd
> > > like to have the third one pushed asap.
> > > 
> > > So ACK to the third patch. I think it matches what we agreed on IRC --
> > > only positive match from logind is now authoritative, negative is only
> > > taken into account if checking proc failed.
> > 
> > You really need the first one too. It fixes a bug that causes issues on
> > authentication.
> > 
> > Simo.
> 
> OK, ACK to the first patch, too. I haven't found any issues with it
> (although I must confess I only tested with DIR cache).

Patch #1 pushed to master and sssd-1-11
Patch #2 needs revision
Patch #3 pushed to master only (as we don't have logind support in 1.11)



More information about the sssd-devel mailing list