[SSSD] [PATCH] NSS: Set UID and GID to negative cache after searching all domains

Simo Sorce simo at redhat.com
Wed Sep 18 17:41:36 UTC 2013


On Wed, 2013-09-18 at 17:58 +0200, Jakub Hrozek wrote:
> Hi,
> 
> the first patch fixes the bug that Jean-Baptiste Denis found earlier
> today. In case the lookup was not done using a FQDN, the code would skip
> setting the entries to the ncache.
> 
> The second patch is an incremental improvement. I don't think we should
> abort the whole lookup if setting an entry in negcache would fail. The
> negative cache is a performance optimization after all.

It seem to me that with the first patch you are changing behavior as you
leave 'ret' unchanged to whatever error is returned instead of setting
it to ENOENT before going to 'done'.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list