[SSSD] [PATCH] RESPONDER: Use right function prototype

Lukas Slebodnik lslebodn at redhat.com
Wed Sep 18 17:10:36 UTC 2013


ehlo,

Protype of function sss_ncache_check_netgr was different than
definition of function sss_ncache_check_netgr. We did not catch it,
because header file "responder/common/negcache.h" was not included in
implementation file "responder/common/negcache.c"

Simple patch is attached.

LS
-------------- next part --------------
>From a6419d3031b9c85f294c762527a6b12fc7c9ff03 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Wed, 18 Sep 2013 18:41:08 +0200
Subject: [PATCH] RESPONDER: Use right function prototype

Protype of function sss_ncache_check_netgr was different than
definition of function sss_ncache_check_netgr. We did not catch it,
because header file "responder/common/negcache.h" was not included in
implementation file "responder/common/negcache.c"
---
 src/responder/common/negcache.c | 1 +
 src/responder/common/negcache.h | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/responder/common/negcache.c b/src/responder/common/negcache.c
index 1f95b1b6dd7a3c333eb21d54e873b8003ddde45c..62c1537f25c71bf7d763e445b97d64655a5703f9 100644
--- a/src/responder/common/negcache.c
+++ b/src/responder/common/negcache.c
@@ -25,6 +25,7 @@
 #include <fcntl.h>
 #include <time.h>
 #include "tdb.h"
+#include "responder/common/negcache.h"
 
 #define NC_ENTRY_PREFIX "NCE/"
 #define NC_USER_PREFIX NC_ENTRY_PREFIX"USER"
diff --git a/src/responder/common/negcache.h b/src/responder/common/negcache.h
index 0b7e00b014da036ff2dc1812e09f1ba3d2c75fd8..b8d385a95df7c3445f8af938fbec6ca4cf0d522d 100644
--- a/src/responder/common/negcache.h
+++ b/src/responder/common/negcache.h
@@ -33,7 +33,7 @@ int sss_ncache_check_user(struct sss_nc_ctx *ctx, int ttl,
 int sss_ncache_check_group(struct sss_nc_ctx *ctx, int ttl,
                            struct sss_domain_info *dom, const char *name);
 int sss_ncache_check_netgr(struct sss_nc_ctx *ctx, int ttl,
-                           const char *domain, const char *name);
+                           struct sss_domain_info *dom, const char *name);
 int sss_ncache_check_uid(struct sss_nc_ctx *ctx, int ttl, uid_t uid);
 int sss_ncache_check_gid(struct sss_nc_ctx *ctx, int ttl, gid_t gid);
 int sss_ncache_check_sid(struct sss_nc_ctx *ctx, int ttl, const char *sid);
-- 
1.8.3.1



More information about the sssd-devel mailing list