[SSSD] [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not available

Sumit Bose sbose at redhat.com
Tue Sep 17 11:00:07 UTC 2013


Hi,

I found this on a system where systemd-devel was not installed. Since we
already know that systemd is available at this stage of the configure
run I wonder if AC_MSG_NOTICE is ok or if AC_MSG_ERROR asking to install
systemd-devel would be better?

bye,
Sumit
-------------- next part --------------
From fd2e8098aa53603172a6070ea423cecc7b4230c5 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Tue, 17 Sep 2013 12:31:45 +0200
Subject: [PATCH] Do not set HAVE_SYSTEMD_LOGIN if libsystemd-login is not
 available

Even if HAVE_SYSTEMD_LOGIN is set to 0 #ifdef will still see it as
defined.
---
 src/external/systemd.m4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/external/systemd.m4 b/src/external/systemd.m4
index 202915a..9afb65d 100644
--- a/src/external/systemd.m4
+++ b/src/external/systemd.m4
@@ -9,4 +9,4 @@ AC_DEFUN([AM_CHECK_SYSTEMD],
 AM_COND_IF([HAVE_SYSTEMD],
            [PKG_CHECK_MODULES([SYSTEMD_LOGIN], [libsystemd-login],
             [AC_DEFINE_UNQUOTED(HAVE_SYSTEMD_LOGIN, 1, [Build with libsystemdlogin support])],
-            [AC_DEFINE_UNQUOTED(HAVE_SYSTEMD_LOGIN, 0, [Build without libsystemd-login support])])])
+            [AC_MSG_NOTICE([Build without libsystemd-login support])])])
-- 
1.7.7.6



More information about the sssd-devel mailing list