[SSSD] [PATCH] Use systemd-login session information to check if user is logged in

Simo Sorce simo at redhat.com
Wed Sep 11 21:47:31 UTC 2013


On Wed, 2013-09-11 at 19:19 +0200, Jakub Hrozek wrote:
> On Wed, Sep 11, 2013 at 10:26:41AM -0400, Simo Sorce wrote:
> > This patch was meant to remove the trolling of /proc for uids but I
> > haven't got there yet.
> > I meant to use utmp as a fallback but I realized utmp does not deal with
> > uid numbers rather usernames, and I need to think if it makes sense to
> > go that way as it may be hairy when we use subdomains as now I need to
> > know what kind of user name was used (fully qualified or not etcc.).
> > 
> > So for now I left the old code as a fallback in case systemd is not
> > available or fails unexpectedly.
> > 
> > Ticket: #2084
> > 
> > Simo.
> > +#ifdef HAVE_SYSTEMD_LOGIN
> > +    ret = sd_uid_get_sessions(uid, 0, NULL);
> > +    if (ret > 0) {
> > +        *result = true;
> > +    }
> > +    if (ret == 0) {
> > +        *result = false;
> > +    }
> > +    if (ret >= 0) {
> > +        return EOK;
> > +    }
> > +    DEBUG(0, ("systemd-login gave error %d: %s\n",
> > +              -ret, strerror(-ret)));
> > +    /* fall back to the old method */
> 
> Please use SSSDBG here.

attached.

>  Otherwise the code looks OK. Can you also open a
> ticket to to document this change in behaviour either in man page or at
> the very least the release notes?

I already have a ticket for this change, so I added a release note in
that appropriate field there.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-util-Use-systemd-login-to-check-user-sessions.patch
Type: text/x-patch
Size: 6085 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130911/5f54b3ce/attachment.bin>


More information about the sssd-devel mailing list