[SSSD] [PATCH] Include sys/types.h for types id_t and uid_t

Jakub Hrozek jhrozek at redhat.com
Tue Sep 3 13:54:52 UTC 2013


On Tue, Sep 03, 2013 at 02:00:09PM +0200, Jakub Hrozek wrote:
> On Tue, Sep 03, 2013 at 10:16:37AM +0200, Sumit Bose wrote:
> > On Mon, Sep 02, 2013 at 07:12:51PM +0200, Lukas Slebodnik wrote:
> > > ehlo,
> > > 
> > > I checked some manual pages, where [ug]?id types are used and each manual page
> > > suggest to include header file "sys/types.h". This header file was indirectly
> > > included in some files on linux, but it is not portable.
> > > 
> > > man getgid
> > >   #include <unistd.h>
> > >   #include <sys/types.h>
> > > 
> > >   gid_t getgid(void);
> > >   gid_t getegid(void);
> > > -------------------------
> > > man getpwuid
> > >   #include <sys/types.h>
> > >   #include <pwd.h>     
> > > 
> > >   struct passwd *getpwuid(uid_t uid);
> > > 
> > > Attached patch modify header file "sss_idmap.h". Should be version-info changed
> > > for libsssidmap?
> > > 
> > > LS
> > 
> > good catch, especially for sss_idmap.h. Imo header files should try to
> > be self contained, i.e. does not need extra includes to get loaded
> > properly, and since libsssidmap is a somewhat public it is even more
> > important.
> > 
> > About version-info, if you follow the book
> > (http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html)
> > letter by letter I guess the revison should be incremented but I thin it
> > is not necessary for the given change.
> > 
> 
> I think this would only be an issue if someone had their own uid_t
> implementation somewhere. I think this is OK as-is.
> 
> > ACK
> 
> Pushed to master.

Also pushed to sssd-1-10 and sssd-1-9 (as the BSD will rebase to 1.9)



More information about the sssd-devel mailing list