[SSSD] [PATCH] dyndns: do not modify global family_order

Sumit Bose sbose at redhat.com
Tue Sep 3 10:57:13 UTC 2013


Hi,

this issue was discovered by a user and as far as I can see it was
always there. Feel free to apply it to older branches as well.

bye,
Sumit
-------------- next part --------------
From 1d0f9a79a0e0f58082ab28725515af378a19524e Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Mon, 2 Sep 2013 17:35:23 +0200
Subject: [PATCH] dyndns: do not modify global family_order

Resolves:
https://fedorahosted.org/sssd/ticket/2063
---
 src/providers/dp_dyndns.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/providers/dp_dyndns.c b/src/providers/dp_dyndns.c
index 488c2a6..7a342d1 100644
--- a/src/providers/dp_dyndns.c
+++ b/src/providers/dp_dyndns.c
@@ -634,6 +634,7 @@ nsupdate_get_addrs_done(struct tevent_req *subreq)
     struct sss_iface_addr *addr;
     int i;
     int resolv_status;
+    enum restrict_family retry_family_order;
 
     ret = resolv_gethostbyname_recv(subreq, state, &resolv_status, NULL,
                                     &rhostent);
@@ -698,15 +699,14 @@ nsupdate_get_addrs_done(struct tevent_req *subreq)
         (state->be_res->family_order == IPV6_FIRST &&
          rhostent->family == AF_INET6))) {
 
-        state->be_res->family_order = \
-                            (state->be_res->family_order == IPV4_FIRST) ? \
+        retry_family_order = (state->be_res->family_order == IPV4_FIRST) ? \
                              IPV6_ONLY : \
                              IPV4_ONLY;
 
         subreq = resolv_gethostbyname_send(state, state->ev,
                                            state->be_res->resolv,
                                            state->hostname,
-                                           state->be_res->family_order,
+                                           retry_family_order,
                                            state->db);
         if (!subreq) {
             ret = ENOMEM;
-- 
1.7.7.6



More information about the sssd-devel mailing list