[SSSD] [PATCHES] simple access provider: support subdomain users and groups

Pavel Březina pbrezina at redhat.com
Tue Sep 3 10:42:21 UTC 2013


Patch 0001:
I haven't used this one after all, but I still think it is nice to have. 
It reduces amount of code duplication.

Patch 0005:
> +    /* Try to get group SID and assign it a domain */
> +    group_sid = ldb_msg_find_attr_as_string(group, SYSDB_SID_STR, NULL);
> +    if (group_sid == NULL) {

I'm not sure if this branch isn't a dead code, but I kept it there 
because it mimics current behaviour.

> +        /* We will look it up in main domain. */
> +        domain = state->ctx->domain;
> +    } else {
> +        domain = find_subdomain_by_sid(state->ctx->domain, group_sid);
> +        if (domain == NULL) {
> +            DEBUG(SSSDBG_CRIT_FAILURE, ("There is no domain information for "
> +                                        "SID %s\n", group_sid));
> +            return ENOENT;
> +        }
> +    }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-util-add-sss_idmap_talloc-_free.patch
Type: text/x-patch
Size: 10269 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130903/248f5956/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-simple-access-tests-fix-typos.patch
Type: text/x-patch
Size: 2177 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130903/248f5956/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-simple-provider-support-subdomain-users.patch
Type: text/x-patch
Size: 1714 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130903/248f5956/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-util-add-find_subdomain_by_sid.patch
Type: text/x-patch
Size: 2941 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130903/248f5956/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-simple-provider-support-subdomain-groups.patch
Type: text/x-patch
Size: 9926 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130903/248f5956/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-simple-access-test-initialize-be_ctx-for-all-tests.patch
Type: text/x-patch
Size: 2885 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130903/248f5956/attachment-0005.bin>


More information about the sssd-devel mailing list