[SSSD] [PATCH] Makefile: Add missing libraries

Lukas Slebodnik lslebodn at redhat.com
Wed Oct 30 13:15:04 UTC 2013


ehlo,

I tried to build latest sssd master on ubuntu and some tests could not be
linked. It is caused by disabled link_all_deplibs.

LS
-------------- next part --------------
>From 3557b4a3d6ac9b3a07ef9694377c155e07e71ba9 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Wed, 30 Oct 2013 12:04:04 +0100
Subject: [PATCH 1/2] Makefile: Add missing libraries

If sssd is compiled with disabled link_all_deplibs (debian) some test could not
be properly linked. This patch add missing libraries
---
 Makefile.am | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Makefile.am b/Makefile.am
index f12e44495c2be855e8b6f815961c7eb77b812fdf..c7e32eb7c4a95dc22bf618bff4238f4c5bffc162 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -908,6 +908,8 @@ libsss_test_common_la_SOURCES = \
     src/tests/common_dom.c \
     src/tests/leak_check.c \
     src/tests/common.c
+libsss_test_common_la_LIBADD = \
+    $(TALLOC_LIBS)
 
 if HAVE_CHECK
 libsss_test_common_la_SOURCES += \
@@ -1377,6 +1379,7 @@ test_sss_idmap_CFLAGS = \
     $(AM_CFLAGS)
 test_sss_idmap_LDADD = \
     $(CMOCKA_LIBS) \
+    $(POPT_LIBS) \
     libsss_idmap.la \
     $(SSSD_INTERNAL_LTLIBS) \
     libsss_test_common.la
@@ -1388,6 +1391,7 @@ test_utils_CFLAGS = \
     $(AM_CFLAGS)
 test_utils_LDADD = \
     $(CMOCKA_LIBS) \
+    $(POPT_LIBS) \
     $(SSSD_INTERNAL_LTLIBS) \
     libsss_test_common.la
 
-- 
1.8.3.1

-------------- next part --------------
>From 8489fc8d96da9047bf32a7a3d09e66d4fdd60621 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Wed, 30 Oct 2013 12:06:53 +0100
Subject: [PATCH 2/2] Makefile: Remove unused variable TEST_MOCK_OBJ

---
 Makefile.am | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index c7e32eb7c4a95dc22bf618bff4238f4c5bffc162..282659610b772201f33e08fc4cc69cb241b10d96 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1362,7 +1362,6 @@ dyndns_tests_LDADD = \
     libsss_test_common.la
 
 fqnames_tests_SOURCES = \
-    $(TEST_MOCK_OBJ) \
     src/tests/cmocka/test_fqnames.c
 fqnames_tests_CFLAGS = \
     $(AM_CFLAGS)
@@ -1373,7 +1372,6 @@ fqnames_tests_LDADD = \
     libsss_test_common.la
 
 test_sss_idmap_SOURCES = \
-    $(TEST_MOCK_OBJ) \
     src/tests/cmocka/test_sss_idmap.c
 test_sss_idmap_CFLAGS = \
     $(AM_CFLAGS)
@@ -1385,7 +1383,6 @@ test_sss_idmap_LDADD = \
     libsss_test_common.la
 
 test_utils_SOURCES = \
-    $(TEST_MOCK_OBJ) \
     src/tests/cmocka/test_utils.c
 test_utils_CFLAGS = \
     $(AM_CFLAGS)
@@ -1396,7 +1393,6 @@ test_utils_LDADD = \
     libsss_test_common.la
 
 ad_access_filter_tests_SOURCES = \
-    $(TEST_MOCK_OBJ) \
     $(sssd_be_SOURCES) \
     src/util/sss_ldap.c \
     src/util/sss_krb5.c \
-- 
1.8.3.1



More information about the sssd-devel mailing list