[SSSD] [PATCHES] dp: free sdap domain if subdomain is removed

Sumit Bose sbose at redhat.com
Fri Oct 25 14:56:58 UTC 2013


On Fri, Oct 25, 2013 at 03:09:54PM +0200, Pavel Březina wrote:
> On 10/25/2013 02:44 PM, Sumit Bose wrote:
> >On Thu, Oct 24, 2013 at 01:13:25PM +0200, Pavel Březina wrote:
> >>https://fedorahosted.org/sssd/ticket/1968
> >
> >The patches do not cleanly apply to current master, can you send a
> >rebased version?
> >
> >bye,
> >Sumit
> 
> Hi,
> those patches apply cleanly to current master. Are you sure you have
> the current master?

yes, sorry, my fault.

I have some concerns about patch [PATCH 04/10] 'dp: set request domain'.
I'm not sure if there is some code in one of the backends which expects
that be_req->domain is the parent domain.

I would suggest to either add a new member to struct be_req to save the
domain name or add some kind of garbage collection ptasks. If there are
no active requests the ptask can remove and sdap domains which do not
have a domain anymore.

bye,
Sumit
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel



More information about the sssd-devel mailing list