[SSSD] [PATCHES] IPA: add trusted domains with missing idrange

Jakub Hrozek jhrozek at redhat.com
Fri Oct 25 10:17:38 UTC 2013


On Fri, Oct 25, 2013 at 12:06:25PM +0200, Sumit Bose wrote:
> On Fri, Oct 25, 2013 at 11:21:28AM +0200, Jakub Hrozek wrote:
> > On Thu, Oct 24, 2013 at 02:14:59PM +0200, Sumit Bose wrote:
> > > Hi,
> > > 
> > > this patch set tries to fix https://fedorahosted.org/sssd/ticket/2101 .
> > > Currently we rely on the fact that the external mapping is the default
> > > in the case of an error. But this leads to a loot of useless CPU cycles
> > > and maybe irritating error messages. With this patch set each trusted AD
> > > member domain gets a proper range assigned if the forest root is
> > > configured to manage the POSIX attributes.
> > > 
> > > bye,
> > > Sumit
> > 
> > Hi,
> > 
> > I only have two minor comments, see below:
> > 
> > > From e1a86771137f67e0e8d24c4bbb014bfc21d85538 Mon Sep 17 00:00:00 2001
> > > From: Sumit Bose <sbose at redhat.com>
> > > Date: Wed, 23 Oct 2013 14:39:55 +0200
> > > Subject: [PATCH 1/4] find_subdomain_by_sid: skip domains with missing
> > >  domain_id
> > 
> > ACK. Thanks for the unit test.
> > 
> > > From dc0115802904c954c79d90cd846da9f5bd965019 Mon Sep 17 00:00:00 2001
> > > From: Sumit Bose <sbose at redhat.com>
> > > Date: Thu, 24 Oct 2013 11:44:11 +0200
> > > Subject: [PATCH 2/4] idmap: add
> > >  sss_idmap_domain_by_name_has_algorithmic_mapping()
> > 
> > The code itself is good, but we need to bump the version number. See the
> > attached patch, can you squash it in if you agree?
> 
> There was no patch but I changed version-info to 2:0:2. Is this what you
> would suggest?

Oops, sorry. Yes, that was how I read the libtool manual as well. The
resulting soname (not libtool info) will be 0.2.0



More information about the sssd-devel mailing list