[SSSD] [PATCH] Include external headers with #include <foo.h>

Lukas Slebodnik lslebodn at redhat.com
Tue Oct 22 13:10:32 UTC 2013


On (22/10/13 10:41), Jakub Hrozek wrote:
>On Tue, Oct 22, 2013 at 10:34:48AM +0200, Lukas Slebodnik wrote:
>> On (22/10/13 09:17), Jakub Hrozek wrote:
>> >On Mon, Oct 21, 2013 at 08:17:00AM -0400, Stephen Gallagher wrote:
>> >> -----BEGIN PGP SIGNED MESSAGE-----
>> >> Hash: SHA1
>> >> 
>> >> On 10/21/2013 05:28 AM, Jakub Hrozek wrote:
>> >> > Attached is a style patch. Feel free to ack or nack, it's just a 
>> >> > readability improvement.
>> >> > 
>> >> 
>> >> Ack. I agree, out-of-tree headers should be using <>
>> >> 
>> >> A fair number of these are pointing at the ding-libs headers, which
>> >> once upon a time were in-tree, so I guess that excuses them somewhat.
>> >
>> >Pushed to master.
>> 
>> I should do review earlier.
>> 
>> {dbus.h, ldb_errors.h, popt.h, talloc.h} are included correctly,
>> but there are few issues with anoter header files in current master.
>> 
>> git grep \"dhash.h\"
>> src/ldb_modules/memberof.c:#include "dhash.h"
>> src/providers/krb5/krb5_delayed_online_authentication.c:#include "dhash.h"
>> src/responder/nss/nsssrv_private.h:#include "dhash.h"
>> src/tests/cmocka/test_find_uid.c:#include "dhash.h"
>> src/util/find_uid.c:#include "dhash.h"
>> src/util/find_uid.h:#include "dhash.h"
>> 
>> git grep \"ldb.h\"
>> src/tools/sss_debuglevel.c:#include "ldb.h"
>> src/util/server.c:#include "ldb.h"
>> 
>> git grep \"tevent.h\"
>> src/sbus/sbus_client.h:#include "tevent.h"
>
>You can send another patch :-)

We can let new contributor to do this easy job.

LS



More information about the sssd-devel mailing list