[SSSD] [INI][PATCHES] Allow c-style comments in config files

Dmitri Pal dpal at redhat.com
Mon Oct 21 18:54:39 UTC 2013


On 10/21/2013 12:15 PM, Lukas Slebodnik wrote:
> On (19/10/13 01:08), Dmitri Pal wrote:
>> On 10/17/2013 10:39 AM, Lukas Slebodnik wrote:
>>> On (06/10/13 12:29), Dmitri Pal wrote:
>>>> Hello
>>>>
>>>> The following patch set addresses ticket
>>>> https://fedorahosted.org/sssd/ticket/2108
>>>>
>>>> Please see commit messages for more details about what each patch does.
>>>> Please follow the order of the patches in the set.
>>>>
>>>> -- 
>>>> Thank you,
>>>> Dmitri Pal
>>>>
>>>> Sr. Engineering Manager for IdM portfolio
>>>> Red Hat Inc.
>>>>
>>>>
>>> Code looks good to me and is quite simple.
>>> I would like to give an ACK, but I have a few notes.
>>>
>>> The most confusing thing to me was:
>>>    c-style comments *HAVE TO* start at the beginning of line.
>>>
>>> I think it can be also confusing for other users,
>>> because a lot of people use /* */ anywhere.
>>> For example to describe members of structure and users may expect the same
>>> behaviour in libini.
>> This is why it is documented that it is not allowed to start not at the
>> beginning of the line.
>> The support of c-style comments is added to be able to parse windows
>> config files.
>> So far all files I have seen follow the convention.
> I tried to find c-style comments in "*.ini" files on windows, but I cannot
> find any.
> Comments in windows ini files start with char ';'
>
> If we want to be able parse windows config files we should support
> semicolon-style comments
>
> LS
The files that are used in GPO at not exactly ini files. They have other
extensions.
Here is the file that comes from Windows that I have been testing with:
https://fedorahosted.org/sssd/attachment/ticket/2119/symbols.conf
It is added to unit tests at the end of the big patch set.

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager for IdM portfolio
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/






More information about the sssd-devel mailing list