[SSSD] [PATCH] Remove duplicate declaration

Lukas Slebodnik lslebodn at redhat.com
Mon Oct 21 14:48:16 UTC 2013


On (21/10/13 11:27), Jakub Hrozek wrote:
>sss_parse_name() was declared twice for no apparent reason. This patch
>removes the duplicate declaration.

>From 9634c03d1f755eb6de9f2c3fcd6bd5cb46f1bebe Mon Sep 17 00:00:00 2001
>From: Jakub Hrozek <jhrozek at redhat.com>
>Date: Wed, 2 Oct 2013 14:58:30 +0200
>Subject: [PATCH] Remove duplicate declaration
>
>---
> src/responder/common/responder.h | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/src/responder/common/responder.h b/src/responder/common/responder.h
>index fad16eb8913a673a85c187538a32937afb490f9f..c1b699de143d786eb7c2eb1c809981f9a8d1f82e 100644
>--- a/src/responder/common/responder.h
>+++ b/src/responder/common/responder.h
>@@ -159,10 +159,6 @@ int sss_process_init(TALLOC_CTX *mem_ctx,
>                      struct sbus_interface *dp_intf,
>                      struct resp_ctx **responder_ctx);
> 
>-int sss_parse_name(TALLOC_CTX *memctx,
>-                   struct sss_names_ctx *snctx,
>-                   const char *orig, char **domain, char **name);
>-
> int sss_parse_name_for_domains(TALLOC_CTX *memctx,
>                                struct sss_domain_info *domains,
>                                const char *default_domain,
>-- 
>1.8.3.1
>

Nice catch.

sss_parse_name is defined in src/util/usertools.c
and declarations were in header files:
   src/responder/common/responder.h src/util/util.h:int
sss_parse_name is used in {providers, responders and tools}

sss_parse_name_for_domains is also defined in src/util/usertools.c
   declaration is only in header file src/responder/common/responder.h
sss_parse_name_for_domains is used only in responders.

And now question:
Does it make sense to move declaration into util.h ?

LS



More information about the sssd-devel mailing list