[SSSD] [PATCH] nss: wait for initial subdomains request to finish

Jakub Hrozek jhrozek at redhat.com
Thu Oct 17 15:42:28 UTC 2013


On Thu, Oct 17, 2013 at 02:15:57PM +0200, Sumit Bose wrote:
> On Thu, Oct 17, 2013 at 01:33:41PM +0200, Jakub Hrozek wrote:
> > On Thu, Oct 17, 2013 at 01:23:02PM +0200, Sumit Bose wrote:
> > > On Thu, Oct 17, 2013 at 10:59:47AM +0200, Pavel Březina wrote:
> > > > https://fedorahosted.org/sssd/ticket/2092
> > > 
> > > > From d363ac390df58435a8cf83098a1407689f1f5db4 Mon Sep 17 00:00:00 2001
> > > > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina at redhat.com>
> > > > Date: Thu, 17 Oct 2013 10:20:56 +0200
> > > > Subject: [PATCH] nss: wait for initial subdomains request to finish
> > > > 
> > > > AD provider downloads domain information and initalizes ID mapping
> > > > during subdomains request. This information is necessary to lookup
> > > > objects without POSIX attributes.
> > > > 
> > > > We need to make sure that we postpone all responder requests until
> > > > ID mapping is initialized in the provider.
> > > > 
> > > > Resolves:
> > > > https://fedorahosted.org/sssd/ticket/2092
> > > 
> > > I haven't tested the patch yet, but I think it is a good solution for
> > > the present issue although it might lead to some additional cycles for
> > > environments without subdomains.
> > > 
> > > I wonder if a more general solution to the issue would be to let the
> > > backend only send a response to a DP_METHOD_REGISTER request if the
> > > backend is fully initialized?  Currently the response is send
> > > immediately. I think this change is out of scope for 1.11 but if you
> > > agree I can open a ticket with this suggestion and a hint to remove this
> > > patch if it is implemented?
> > > 
> > > bye,
> > > Sumit
> > 
> > Please do.
> 
> https://fedorahosted.org/sssd/ticket/2122

Thanks!

I tested Pavel's patch together with
c2aeea38addda1a07e60adbc3451f11b640f7bf1 reverted as Pavel suggested.

 * with clean master the resolution worked for me, so I didn't have much
   luck reproducing the error
 * with clean master and c2aeea reverted, the lookups failed in more
   than half of the attempts
 * with clean master, c2aeea reverted and Pavel's patch, the lookups
   were working fine all the time

The code looks good, ACK



More information about the sssd-devel mailing list