[SSSD] [PATCH] krb5: Check return value of sss_krb5_princ_realm

Pavel Březina pbrezina at redhat.com
Tue Oct 15 11:59:28 UTC 2013


On 10/14/2013 11:50 AM, Lukas Slebodnik wrote:
> ehlo,
>
> yet another warning from clang static analyser.
>
> sss_krb5_princ_realm set output parameter realm to NULL and len to 0
> in case of failure. Clang static analysers repoted warning
> "Null pointer passed as an argument to a 'nonnull' parameter"
> in function match_principal. It was possible, that realm_name with value NULL
> could be used in strncmp.
>
> Function sss_krb5_princ_realm is used on other places for printing(formatting)
> realm_name and NULL can be safely used as a argument for printf-like
> functions.
>
> Patch is attached.
>
> LS

The returned value should be checked on other references as well.




More information about the sssd-devel mailing list