[SSSD] [PATCH] LDAP: Set default value for dyndns update to false

Lukas Slebodnik lslebodn at redhat.com
Mon Oct 14 12:36:56 UTC 2013


ehlo,

In some cases, local boolean variable "do_update" could be used
without proper initialisation.
Clang static analyser warning: "Assigned value is garbage or undefined"
It was not a big problem, because non-zero value for boolean variable mean
true.

Simple patch is attached.

LS
-------------- next part --------------
>From 0325b79a58330f9d3d14caaa33fb1cb3436b61bc Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Mon, 14 Oct 2013 14:26:20 +0200
Subject: [PATCH] LDAP: Set default value for dyndns update to false

In some cases, local boolean variable "do_update" could be used
without proper initialisation.
Clang static analyser warning: "Assigned value is garbage or undefined"
It was not a big problem, because non-zero value for boolean variable mean
true.
---
 src/providers/ldap/sdap_dyndns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/providers/ldap/sdap_dyndns.c b/src/providers/ldap/sdap_dyndns.c
index bf5fb099eec75439125c2468a27e4ec0a46523e1..7bcf64f3583c0a20b78eb6cb55ab85bbe086e98f 100644
--- a/src/providers/ldap/sdap_dyndns.c
+++ b/src/providers/ldap/sdap_dyndns.c
@@ -251,7 +251,7 @@ sdap_dyndns_addrs_diff(struct sdap_dyndns_update_state *state, bool *_do_update)
     int i;
     char **str_dnslist = NULL, **str_local_list = NULL;
     char **dns_only = NULL, **local_only = NULL;
-    bool do_update;
+    bool do_update = false;
 
     ret = sss_iface_addr_list_as_str_list(state,
                                           state->dns_addrlist, &str_dnslist);
-- 
1.8.3.1



More information about the sssd-devel mailing list