[SSSD] [PATCH 2/4] Move DEBUG macro body to debug_fn
Nikolai Kondrashov
Nikolai.Kondrashov at redhat.com
Fri Oct 11 08:31:08 UTC 2013
Hi Simo,
On 10/10/2013 11:25 PM, Simo Sorce wrote:
> Hi Nikolai,
> nice work.
Thanks :)
> The code size reduction looks appealing, however please check the level
> before calling the function, directly in the DEBUG() macro.
> This way we completely avoid the function call when we are not going to
> debug anything.
Yes, that might help with the cache.
> Also please squash the fflush patch into this one, I do not really see a
> good reason to have 2 patches given, afaics, you introduced the issue
> with this patch in the first place.
Sorry, no, it was there before my changes, so I will keep it separate for the
next round. Please respond if you would like it otherwise.
Sincerely,
Nick
More information about the sssd-devel
mailing list