[SSSD] [PATCH 3/4] Make DEBUG macro variadic

Jakub Hrozek jhrozek at redhat.com
Fri Oct 11 08:17:07 UTC 2013


On Fri, Oct 11, 2013 at 11:09:35AM +0300, Nikolai Kondrashov wrote:
> On 10/10/2013 11:27 PM, Simo Sorce wrote:
> >On Thu, 2013-10-10 at 15:46 -0400, Stephen Gallagher wrote:
> >>-----BEGIN PGP SIGNED MESSAGE-----
> >>Hash: SHA1
> >>
> >>On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote:
> >>>Make DEBUG macro accept variable number of arguments, thus removing
> >>>the need to wrap the format string and its arguments into parens
> >>>on invocation.
> >>
> >>Nack.
> >>
> >>Please do us a favor and split this into two patches, one that makes
> >>the change to the macro definition and one that bulk-updates the
> >>existing messages. Having a 2.2MB patch file with a few small changes
> >>buried in it somewhere is very difficult to review. I'm not confident
> >>I can locate the real changes amidst the find-replace noise.
> >
> >I would not want to consider such a patch in any case. The churn is just
> >too extraordinarily big and I do not see enough value to warrant it.
> >
> >The patch is so immense that is it impossible to review, so we would
> >have to make a leap of faith in assuming every single change did not
> >introduce errors.
> 
> I'll try to reduce the amount of faith required. Maybe try a semantic patch
> [1], or do some metrics on the code and the changes.

Can you also send the next round of patches gzipped so that you don't
have to wait until they make it through moderation?



More information about the sssd-devel mailing list