[SSSD] [PATCH] LDAP: Delete entry by SID if not found

Sumit Bose sbose at redhat.com
Fri Oct 11 07:37:54 UTC 2013


On Thu, Oct 10, 2013 at 02:49:13PM -0400, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 10/10/2013 02:13 PM, Jakub Hrozek wrote:
> > Hi,
> > 
> > if an entry is removed from LDAP and searched by SID, the SID
> > lookup code doesn't handle ENOENT and doesn't remove the stray
> > entry from cache. The attached patch fixes that.
> > 
> 
> One minor nitpick (no need to resend for review): the
> SSSBG_FATAL_FAILURE line is > 79 characters. Please reflow it.
> 
> Otherwise, code looks good to me. Ack.

I agree, I just wonder if the new code can be move to a new call like
e.g. sysdb_delete_by_sid() to make it easier to reuse it?

bye,
Sumit

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.14 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> 
> iEYEARECAAYFAlJW9qkACgkQeiVVYja6o6Oc5wCfUV2IF3ZRlJRTj2xjqvAC08QV
> tdkAnRoFnbDJzxuNjEcTgEneZSJtFUrk
> =7ZOt
> -----END PGP SIGNATURE-----
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel



More information about the sssd-devel mailing list