[SSSD] [PATCH 3/4] Make DEBUG macro variadic

Stephen Gallagher sgallagh at redhat.com
Thu Oct 10 19:46:52 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/10/2013 10:07 AM, Nikolai Kondrashov wrote:
> Make DEBUG macro accept variable number of arguments, thus removing
> the need to wrap the format string and its arguments into parens
> on invocation.

Nack.

Please do us a favor and split this into two patches, one that makes
the change to the macro definition and one that bulk-updates the
existing messages. Having a 2.2MB patch file with a few small changes
buried in it somewhere is very difficult to review. I'm not confident
I can locate the real changes amidst the find-replace noise.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlJXBCwACgkQeiVVYja6o6PG5gCfWROquQAhQUQ0yOI+HMW0/hOy
6tAAnAu24fpWGdJwuD5zQ2AZ3fcdZR0G
=+0E+
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list