[SSSD] [PATCHES] Remove unused parameter after sysdb refactoring

Jakub Hrozek jhrozek at redhat.com
Wed Nov 27 17:30:54 UTC 2013


On Tue, Nov 26, 2013 at 03:30:56PM +0100, Michal Židek wrote:
> On 11/26/2013 02:51 PM, Lukas Slebodnik wrote:
> >On (21/11/13 14:10), Michal Židek wrote:
> >>On 11/15/2013 11:59 PM, Lukas Slebodnik wrote:
> >>>ehlo,
> >>>
> >>>there are lof of unused parametres in functions after sysdb refactoring.
> >>>Patches are splitted per function for easier review.
> >>>I can reduce count of patches after review.
> >>
> >>Yes, please do that. 26 patches for this change is probably too much.
> >>It is not very big even when squashed into one patch, but 3-4 patches
> >>for better readability will be fine.
> >>
> >>>
> >>>LS
> >>>
> >>
> >>Also please rebase patch 0002. It does not apply on current master.
> >>
> >>Otherwise the patches are OK.
> >>
> >>Michal
> >
> >Rebased patches are in the attached tarball
> >
> >LS
> >
> >
> 
> ACK.
> 
> We discussed off-list with Lukas and decided that the patches do not
> need to be squashed. So ACK to all.
> 
> Michal

I checked the patches real quick again (meld is a great tool for these
reviews btw) and they look good to me too.

Pushed to master.



More information about the sssd-devel mailing list