[SSSD] [PATCH] Specific error message for missing sssd.conf

Jakub Hrozek jhrozek at redhat.com
Fri Nov 22 15:46:57 UTC 2013


On Wed, Nov 20, 2013 at 01:52:42PM +0100, Pavel Reichl wrote:
> New patch hopefully addressing all mentioned issues is attached.
> 
> PR
> 

Hi Pavel,

sorry for the late review.

The patch works fine and mostly looks good, I'm just wondering about one
change. I wonder if this block:

> +        if (ret == ENOENT) {
> +            /* sss specific error denoting missing configuration file */
> +            ret = ERR_MISSING_CONF;
> +        }

Would be better placed in the confdb_init_db() function after the
sss_ini_config_file_open() fails with ENOENT? Not 100% sure what would
look better though.



More information about the sssd-devel mailing list