[SSSD] [PATCHES] ad: use tokengroups even when id mapping is disabled

Pavel Březina pbrezina at redhat.com
Wed Nov 20 13:41:49 UTC 2013


On 11/19/2013 11:52 AM, Jakub Hrozek wrote:
> On Fri, Nov 15, 2013 at 12:22:53PM +0100, Pavel Březina wrote:
>> https://fedorahosted.org/sssd/ticket/1568
>
>>  From b66343b207679cbbbdb5d4a54a7f465fbf2ec97f Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina at redhat.com>
>> Date: Tue, 12 Nov 2013 13:52:35 +0100
>> Subject: [PATCH 1/3] sysdb: add sysdb_group_dn_str()
>
> The patch doesn't apply, but more importantly there already is
> sysdb_group_dn_str(), can you use that instead?

Thanks.

>
> The other two patches don't apply either. I have just a couple of
> comments and questions as I scrolled through them:
>
> Patch #2 looks good to me so far, but I only read the diff.
>
> In patch #3, I don't see the point of using tmp_ctx and stealing to "state"
> later if the request is relatively short. Can you use "state" directly?
> That way you guarantee that the memory will go away with the request.

I don't know, I think freeing all resources when they become irrelevant 
is more clear.

> btw did you test if the code works even if only some of the groups have
> posix attributes set?

Yes, those non-posix groups are downloaded by SID but they have empty 
members.

Rebase patches are attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ad-refactor-tokengroups-initgroups.patch
Type: text/x-patch
Size: 27783 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131120/9059c611/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ad-use-tokengroups-even-when-id-mapping-is-disabled.patch
Type: text/x-patch
Size: 23231 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20131120/9059c611/attachment-0001.bin>


More information about the sssd-devel mailing list