[SSSD] [PATCHES] ad: use tokengroups even when id mapping is disabled

Stephen Gallagher sgallagh at redhat.com
Tue Nov 19 12:56:13 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/19/2013 05:52 AM, Jakub Hrozek wrote:
> In patch #3, I don't see the point of using tmp_ctx and stealing to
> "state" later if the request is relatively short. Can you use
> "state" directly? That way you guarantee that the memory will go
> away with the request.

I disagree with this statement on principal (I haven't read the patches).

Even when it's a short function, we want to make sure that if we
return an error, we clean up any memory that has been allocated during
that function. We don't want to be carrying around any more memory
than we have to. This is also future-proof, as we may eventually end
up with a request that lasts longer than it does today.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlKLX+0ACgkQeiVVYja6o6PtsACePMUw+7EefJKnGMntiy0AjBaL
z5kAoKipZHb5o9wx59cdA8MCg0PmCoKF
=xmJH
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list