[SSSD] [PATCH] TESTS: Remove test dir after successful tests

Lukas Slebodnik lslebodn at redhat.com
Mon Nov 18 14:38:51 UTC 2013


ehlo,

I have my buildir in /dev/shm, therefore I don't run configure with flag
--with-test-dir=/dev/shm. I noticed that directory tests_utils was not removed
after successful test execution. This patch add removing this directory,
similar behaviour is in test_dyndns and test_nss_srv

LS
-------------- next part --------------
>From 6fd3135da1444d8a278d1723b771e52070ce1400 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Mon, 18 Nov 2013 15:21:14 +0100
Subject: [PATCH] TESTS: Remove test dir after successful tests

test_utils removed files from test_dir before test execution, but
files wasn't clean up after successful test execution.
---
 src/tests/cmocka/test_utils.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/tests/cmocka/test_utils.c b/src/tests/cmocka/test_utils.c
index cdf3801a8b58fc713690de31fd9170ccf60cdd5e..f2251271b7d81ac19257120166cc77df5d76efad 100644
--- a/src/tests/cmocka/test_utils.c
+++ b/src/tests/cmocka/test_utils.c
@@ -658,6 +658,7 @@ int main(int argc, const char *argv[])
 {
     poptContext pc;
     int opt;
+    int rv;
     struct poptOption long_options[] = {
         POPT_AUTOHELP
         SSSD_DEBUG_OPTS
@@ -712,5 +713,9 @@ int main(int argc, const char *argv[])
     test_dom_suite_cleanup(TESTS_PATH, TEST_CONF_DB, TEST_SYSDB_FILE);
     test_dom_suite_setup(TESTS_PATH);
 
-    return run_tests(tests);
+    rv = run_tests(tests);
+    if (rv == 0) {
+        test_dom_suite_cleanup(TESTS_PATH, TEST_CONF_DB, TEST_SYSDB_FILE);
+    }
+    return rv;
 }
-- 
1.8.4.2



More information about the sssd-devel mailing list