[SSSD] [Patch] Added null checks to authtok module

Jakub Hrozek jhrozek at redhat.com
Mon Nov 18 10:02:42 UTC 2013


On Sat, Nov 16, 2013 at 09:39:36AM -0500, Simo Sorce wrote:
> On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote:
> > Hello,
> > 
> > Please find the attachment below. Kindly review.
> > 
> I am not really a fan of these null checks, I prefer the code to crash
> in this case because these functions should never be called with an
> empty context.

It's a matter of style mostly I suppose, but do you prefer the code to
crash even for external facing API?

I agree with you when it comes to internal/static functions.



More information about the sssd-devel mailing list