[SSSD] [Patch] Added null checks to authtok module

Lukas Slebodnik lslebodn at redhat.com
Mon Nov 18 09:49:07 UTC 2013


On (16/11/13 09:39), Simo Sorce wrote:
>On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote:
>> Hello,
>> 
>> Please find the attachment below. Kindly review.
>> 
>I am not really a fan of these null checks, I prefer the code to crash
>in this case because these functions should never be called with an
>empty context.
>
>Simo.
>
We can make a compromise. extra runtime check will not be added, but we can use
__attribute__(nonnull), but only to functions with extern modifier.
http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#index-g_t_0040code_007bnonnull_007d-function-attribute-2821


LS



More information about the sssd-devel mailing list