[SSSD] [PATCHES] Drop-redundant-sysdb_ctx-parameter

Lukas Slebodnik lslebodn at redhat.com
Fri Nov 15 16:25:36 UTC 2013


On (15/11/13 16:21), Michal Židek wrote:
>On 11/15/2013 04:15 PM, Michal Židek wrote:
>>On 11/15/2013 03:01 PM, Michal Židek wrote:
>>>>>I tested also patch set "00\d\d-SYSDB-Drop*" and I didn't found any
>>>>>unexpected
>>>>>behaviour. I think it is because unit tests for sysdb cover a lot of
>>>>>use cases.
>>>>>
>>>>>ACK for patch set.
>>>>>
>>>>>LS
>>>>
>>>>0010-SYSDB-Drop-the-sysdb_ctx-parameter-module-sysdb_ops-.patch
>>>>^^^^^^
>>>>This patch broke the compilation of sssd
>>>>
>>>>   CC       src/db/sysdb_ops.lo
>>>>src/db/sysdb_ops.c:444:61: error: too many arguments to function call,
>>>>expected 3, have 4
>>>>     basedn = sysdb_group_dn(domain->sysdb, tmp_ctx, domain, name);
>>>>              ~~~~~~~~~~~~~~                                 ^~~~
>>>>src/db/sysdb.h:336:1: note: 'sysdb_group_dn' declared here
>>>>struct ldb_dn *sysdb_group_dn(TALLOC_CTX *mem_ctx, struct
>>>>sss_domain_info *dom,
>>>>^
>>>>src/db/sysdb_ops.c:559:64: error: too many arguments to function call,
>>>>expected 3, have 4
>>>>     basedn = sysdb_netgroup_dn(domain->sysdb, tmp_ctx, domain, name);
>>>>              ~~~~~~~~~~~~~~~~~                                 ^~~~
>>>>src/db/sysdb.h:338:1: note: 'sysdb_netgroup_dn' declared here
>>>>struct ldb_dn *sysdb_netgroup_dn(TALLOC_CTX *mem_ctx,
>>>>^
>>>>src/db/sysdb_ops.c:664:56: error: too many arguments to function call,
>>>>expected 3, have 4
>>>>     dn = sysdb_user_dn(domain->sysdb, tmp_ctx, domain, name);
>>>>          ~~~~~~~~~~~~~                                 ^~~~
>>>>src/db/sysdb.h:334:1: note: 'sysdb_user_dn' declared here
>>>>struct ldb_dn *sysdb_user_dn(TALLOC_CTX *mem_ctx, struct
>>>>sss_domain_info *dom,
>>>>^
>>>>src/db/sysdb_ops.c:699:57: error: too many arguments to function call,
>>>>expected 3, have 4
>>>>     dn = sysdb_group_dn(domain->sysdb, tmp_ctx, domain, name);
>>>>          ~~~~~~~~~~~~~~                                 ^~~~
>>>>src/db/sysdb.h:336:1: note: 'sysdb_group_dn' declared here
>>>>struct ldb_dn *sysdb_group_dn(TALLOC_CTX *mem_ctx, struct
>>>>sss_domain_info *dom,
>>>>
>>>>and lot of another errors
>>>>
>>>>0011-SYSDB-Drop-the-sysdb_ctx-parameter-module-sysdb_ops-.patch
>>>>^^^^^
>>>>This patch fixed this problem
>>>>
>>>>LS
>>>
>>>
>>>Yes, sorry for that. I screwed the rebasing. But the two patches are
>>>doing basicaly the same thing in the same module, so I just squashed
>>>them.
>>>
>>>Thanks for the review.
>>>
>>>New patches are attached.
>>>
>>>Michal
>>>
>>
>>I posted wrong patches. Sending again.
>>
>>Michal
>>
>
>The last patchset applied only using 3way. This should apply cleanly.
>
>Michal
>

ACK

LS



More information about the sssd-devel mailing list