[SSSD] [PATCH] Build cifs plugin depending on the existence of cifsidmap.h

Jakub Hrozek jhrozek at redhat.com
Tue Nov 12 10:44:10 UTC 2013


On Tue, Nov 12, 2013 at 11:12:36AM +0100, Sumit Bose wrote:
> On Mon, Nov 11, 2013 at 05:29:17PM +0100, Lukas Slebodnik wrote:
> > On (04/11/13 10:36), Simo Sorce wrote:
> > >On Mon, 2013-11-04 at 16:21 +0100, Sumit Bose wrote:
> > >> On Mon, Nov 04, 2013 at 12:05:15PM +0100, Lukas Slebodnik wrote:
> > >> > On (01/11/13 18:41), Sumit Bose wrote:
> > >> > >Hi,
> > >> > >
> > >> > >with this patch it is not required anymore to have cifs-utils-devel
> > >> > >installed for the default build.
> > >> > >
> > >> > >Fixes https://fedorahosted.org/sssd/ticket/2125
> > >> > >
> > >> > >bye,
> > >> > >Sumit
> > >> > 
> > >> > >From 35f5932946d67a943146411a336afac34a78fb90 Mon Sep 17 00:00:00 2001
> > >> > >From: Sumit Bose <sbose at redhat.com>
> > >> > >Date: Fri, 1 Nov 2013 18:33:32 +0100
> > >> > >Subject: [PATCH] Build cifs plugin depending on the existence of cifsidmap.h
> > >> > >
> > >> > >To allow the "configure; make; make install" scheme on systems where
> > >> > >cifsidmap.h is not available the cifs-utils plugin is only build if the
> > >> > >include file is available and not build if it is not available.
> > >> > >
> > >> > >If the configure option --enable-cifs-idmap-plugin is used, configure
> > >> > >will fail if cifsidmap.h is not available.
> > >> > >
> > >> > >Fixes https://fedorahosted.org/sssd/ticket/2125
> > >> > >---
> > >> > > src/external/cifsidmap.m4 | 17 ++++++++++-------
> > >> > > 1 file changed, 10 insertions(+), 7 deletions(-)
> > >> > >
> > >> > >diff --git a/src/external/cifsidmap.m4 b/src/external/cifsidmap.m4
> > >> > >index 53cb8b7..fbcbe65 100644
> > >> > >--- a/src/external/cifsidmap.m4
> > >> > >+++ b/src/external/cifsidmap.m4
> > >> > >@@ -2,15 +2,18 @@ AC_ARG_ENABLE([cifs-idmap-plugin],
> > >> > >               [AS_HELP_STRING([--disable-cifs-idmap-plugin],
> > >> > >                               [do not build CIFS idmap plugin])],
> > >> > >               [build_cifs_idmap_plugin=$enableval],
> > >> > >-              [build_cifs_idmap_plugin=yes])
> > >> > >+              [build_cifs_idmap_plugin=auto])
> > >> > > 
> > >> > >-AS_IF([test x$build_cifs_idmap_plugin = xyes],
> > >> > >-      [AC_CHECK_HEADER([cifsidmap.h], [],
> > >> > >-                       [AC_MSG_ERROR([you must have the cifsidmap header installed to build the idmap plugin])])
> > >> > >-      ])
> > >> > 
> > >> > I have an idea. We can leave default value "yes" and extend AC_MSG_ERROR
> > >> > message. For example:
> > >> > "You can disable cifs plugin with parameter --disable-cifs-idmap-plugin"
> > >> > 
> > >> > Is it a bad idea?
> > >> 
> > >> I would like to hear Simo's opinion on both suggestions, before doing
> > >> any changes.
> > >
> > >As long as it is possible to build without the idmap plugin I do not
> > >really care what is the default, use your best judgment.
> > >The problem is in that not being an option, not in what we use as
> > >default.
> > >
> > >Simo.
> > >
> > >-- 
> > >Simo Sorce * Red Hat, Inc * New York
> > >
> > 
> > It was not clear that cifs-idmap plugin is optional feature of sssd.
> > At least, simo and user from sssd-users were confused.
> > https://lists.fedorahosted.org/pipermail/sssd-users/2013-October/001137.html
> > 
> > Attached patch changes only AC_MSG_ERROR.
> 
> Works for me, ACK.
> 
> bye,
> Sumit

Pushed to master.



More information about the sssd-devel mailing list